Add an example of using using DMA with PIO #468
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterharperuk
force-pushed
the
uart_pio_dma
branch
from
988bccc to
47053b4
Compare
peterharperuk
force-pushed
the
uart_pio_dma
branch
from
47053b4 to
9232a3a
Compare
lurch
reviewed
Jan 26, 2024
peterharperuk
force-pushed
the
uart_pio_dma
branch
from
9232a3a to
3fd5556
Compare
lurch
reviewed
Jan 26, 2024
lurch
reviewed
Jan 26, 2024
peterharperuk
force-pushed
the
uart_pio_dma
branch
from
3fd5556 to
77461c7
Compare
peterharperuk
commented
Jan 29, 2024
peterharperuk
commented
Jan 29, 2024
peterharperuk
commented
Jan 29, 2024
peterharperuk
force-pushed
the
uart_pio_dma
branch
from
77461c7 to
67e3171
Compare
kilograham
reviewed
Nov 19, 2024
peterharperuk
force-pushed
the
uart_pio_dma
branch
from
4e3dc9e to
9ba2c96
Compare
|
Currently it just sends a small buffer. To make it more realistic it might be nice to send more data and maybe send and receive on different cores? |
kilograham
previously approved these changes
Feb 13, 2025
kilograham
reviewed
Feb 13, 2025
kilograham
reviewed
Feb 13, 2025
peterharperuk
force-pushed
the
uart_pio_dma
branch
from
907191a to
5c461c0
Compare
This is already handled by add_shared_irq_handler() and i think it is more confusing to have it here
peterharperuk
commented
Feb 18, 2025
lurch
reviewed
Feb 18, 2025
lurch
reviewed
Feb 18, 2025
| #define USE_DMA_FOR_TX 1 | ||
|
|
||
| #define SERIAL_BAUD 921600 | ||
| #define HARD_UART_INST uart1 |
There was a problem hiding this comment.
Out of curiosity I just did some quick local compile-tests, and this code all still compiles if you replace
#define HARD_UART_INST uart1with
#if !USE_PIO_FOR_RX || !USE_PIO_FOR_TX
#define HARD_UART_INST uart1
#endif😉 (which perhaps makes it clearer that the "hard UART" isn't used at all when PIO is being used for both RX and TX?)
kilograham
approved these changes
Feb 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #467